Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: FL-2279 - Fix Docker image build #924

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Jul 17, 2023

Description

Update the .dockerignore file to fix the Docker image build (see failed action here).

As the dist folder is currently under the .dockerignore file, it is not visible by the docker file. This also means that the .dockerignore file has been pretty useless so far, I would remove it to avoid such issues in the future.

Task: APP-2279

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team July 17, 2023 13:35
@cgero-eth cgero-eth merged commit 392d886 into develop Jul 19, 2023
3 of 4 checks passed
@cgero-eth cgero-eth deleted the fix-FL-2279-fix-docker-image-build branch July 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants